Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation instructions in README.md are out of date #233

Open
charlesmelby opened this issue Apr 25, 2024 · 3 comments
Open

installation instructions in README.md are out of date #233

charlesmelby opened this issue Apr 25, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@charlesmelby
Copy link

What happened?

The posted installation instructions don't work.
I used https://marketplace.upbound.io/providers/crossplane-contrib/provider-kubernetes/v0.13.0 instead.

How can we reproduce it?

What environment did it happen in?

Crossplane version: 1.15.2
Kubernetes: 1.24
Distribution: RKE2

@charlesmelby charlesmelby added the bug Something isn't working label Apr 25, 2024
@jbw976
Copy link
Member

jbw976 commented Apr 25, 2024

Ah good point @charlesmelby, thanks for taking the time to call that out! This looks very similar to a recent update we made to provider-helm to fix a very similarly outdated README.md 😊
crossplane-contrib/provider-helm#220

Do you have any interest in taking that on for this repo too? Always happy for community contributions. The local development steps are more tricky, so a phased approach could be to just start by updating the basic install step(s) in the README - that will provide the most relief by itself.

@charlesmelby
Copy link
Author

@jbw976 Sure why not, I'll do that in a bit when I'm free

@jbw976
Copy link
Member

jbw976 commented May 9, 2024

The most critical part of these README installation instructions has been updated by @scubbo in #239. There is still some more work to update the rest of the readme, e.g. the local development instructions and streamlined set up of in-cluster config (similar to crossplane-contrib/provider-helm#220), but the main problem has been addressed now! 🙇

mad01 pushed a commit to mad01/provider-kubernetes that referenced this issue May 23, 2024
See crossplane-contrib#233

Signed-off-by: Jack Jackson <[email protected]>
Signed-off-by: Alexander Brandstedt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants