autodie is incompatible with Test::MockFile

[toddr]

$>perl -Mautodie -MTest::MockFile -E'my $file = "/log"; my $logg = Test::MockFile->file( $file, "one\ntwo\n"); open(my $fh, "<", $file) or die($!); say <$fh>' 
Can't open '/log' for reading: 'No such file or directory' at -e line 1
190503.133746 [email protected] (/usr/local/cpanel)

$>perl -MTest::MockFile -E'my $file = "/log"; my $logg = Test::MockFile->file( $file, "one\ntwo\n"); open(my $fh, "<", $file) or die($!); say <$fh>'
one
two

[toddr]

On load of Test::MockFile, we need to die if we detect $INC{'autodie.pm'}.

[FGasper]

@toddr: That seems a pretty aggressive approach. It assumes one part of a test won’t use the mock and another won’t use a temp directory.

Is it possible to work with it if there is “no autodie” local to the T::MF usage?

[toddr]

I would have to provide an unimport and so would autodie if it doesn't already. That's a perfectly good phase 2 but that'd be a lot of work.

[FGasper]

Another problem with the idea of making autodie mutually exclusive with this module is that autodie also encompasses non-filesystem operations. I suspect it’s not uncommon, for example, for tests to create a pair of sockets via socketpair and do tests on those. That’s a case where autodie is useful but has nothing to do with T::MF.

[atoomic]

another example

╰─> perl -MTest::MockFile -E 'use autodie; my $f = q[/a/b/c]; my $m = Test::MockFile->file(q[/a/b/c] => 123); say q[ok] if -f $f; open(my $fh, "+<", $f ) or die $!'
ok
Can't open '/a/b/c' with mode '+<': 'No such file or directory' at -e line 1

[FGasper]

It may be better to wait until Leon’s autocroak module is usable than to try to fix this.

[FGasper]

https://github.com/cpanel/p5-Filesys-Restrict (private repo) would also address this, perhaps more neatly.

[tomgreen98]

Im wondering if this needs some effort to work with autodie and similar tools. More and more code we see is using patterns similar to autodie. Being able to mock the filesystem is much nicer than using a temp folder.

There has got to be a way to patch autodie to work with these mocks when Test::MockFile sees autodie or similar is loaded.