Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

Materials are out-of-sync with the template #3

Closed
ooharawork opened this issue Aug 15, 2018 · 4 comments
Closed

Materials are out-of-sync with the template #3

ooharawork opened this issue Aug 15, 2018 · 4 comments
Assignees

Comments

@ooharawork
Copy link

ooharawork commented Aug 15, 2018

As you probably know, the materials are now out-of-sync with recent updates on the template (corda-training-template).
Newer pdfs, that are possibly used in the current course, if any, should be reflected to this repository, for consistency.

Example of updates to be reflected:
In Module 10 - Plugins and APIs.pdf:

@bennytanr3
Copy link
Contributor

bennytanr3 commented Aug 24, 2018

The value of teaching Restful APIs in Jetty has diminished when we consider the deprecation of the webserver in favour of an external package e.g. springboot. In springboot, the implementation for the API would have been different. Good catch nonetheless.

page 14: suggests commenting out in the corda-training-template, GET 'ious'
page 23: Will update the deck to Created
page 34: Will update the deck to rpcOps.startTrackedFlow(::IOUIssueFlow, state)

@ooharawork
Copy link
Author

Thanks for the comment and the amendments. Got that Jetty-based materials will be obsoleted and we should rather move on to springboot etc.
This might be a little bit picky, but IOUIssueFlow:: should be typo of ::IOUIssueFlow in #5 .

@bennytanr3
Copy link
Contributor

Sorry about this, I have updated the deck again.

@ooharawork
Copy link
Author

Thanks again! confirmed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants