Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch for 8.14 #73

Closed
palmskog opened this issue Aug 24, 2021 · 8 comments
Closed

Branch for 8.14 #73

palmskog opened this issue Aug 24, 2021 · 8 comments

Comments

@palmskog
Copy link
Member

The master branch of Paramcoq no longer builds with Coq's v8.14 branch. Yet, the release of 8.14.0 is on the horizon, and I would really like the corresponding Paramcoq release to include the improvements from #70, #71, and #72.

@proux01 do you mind if I push a branch v8.14 here based on 1d9409b (the last commit that builds with Coq's v8.14) with changes from the PRs on top?

@proux01
Copy link
Collaborator

proux01 commented Aug 25, 2021

That would be nice indeed (sorry I'm a bit late on this, I was disturbed by the fact that 8.14 seems in a kind of zombie state this summer).
I'll then release 1.1.3+coq8.14 as soon as 8.14 is out.

@palmskog
Copy link
Member Author

palmskog commented Aug 25, 2021

I pushed the branch. However, due to coq-community/docker-coq#29 I can't use any Docker CI there, so I resort to Nix. This should probably be fixed once the Docker-Coq issue is resolved, since I don't know any way to run the tests in Nix.

@palmskog
Copy link
Member Author

Oh and as a memento, I used the this approach to perform a selective merge. Since I was the author of all the non-merge commits in master that "disappeared" in the v8.14 branch, this doesn't lose any contribution information.

@palmskog
Copy link
Member Author

palmskog commented Aug 25, 2021

@proux01 maybe I could push analogous changes to v8.13 as well? If you then make a release 1.1.3+coq8.13 at the same time as 1.1.3+coq8.14, we could declare #56 solved (at least in this repo, maybe it should be reported upstream).

@proux01
Copy link
Collaborator

proux01 commented Aug 25, 2021

Sure, feel free to.

@palmskog
Copy link
Member Author

OK, I'm done with v8.13 and v8.14. I took the liberty to push a minimal metadata-only update to master. Will keep this issue open until we have full CI for v8.14, though, which may take a week or two.

@proux01
Copy link
Collaborator

proux01 commented Aug 25, 2021

Great, thanks! I'll release 1.1.3+coq8.13 together with 1.1.3+coq8.14.

@proux01
Copy link
Collaborator

proux01 commented Sep 24, 2021

I'm closing this now that we have OPAM packages.

@proux01 proux01 closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants