Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code used to add Last-Modified from mbtiles mtime seems to be removed #183

Open
maloff1 opened this issue Oct 6, 2024 · 1 comment
Open

Comments

@maloff1
Copy link

maloff1 commented Oct 6, 2024

This commit f446948 from this pull request from 2016 #25 added Last-Modified header with date from mbtiles.

This code seems to be missing from the current codebase.

I think this header is useful for caching, and before I start hacking and make a pull request to return alike code, can someone please point out if removal happened because of well thought out considerations, or this was an omission during some later rewrite?

@maloff1 maloff1 changed the title Code to add Last-Modified http header of mbtiles' mtime seems to be removed Code were used to add Last-Modified from mbtiles mtime seems to be removed Oct 6, 2024
@maloff1 maloff1 changed the title Code were used to add Last-Modified from mbtiles mtime seems to be removed Code used to add Last-Modified from mbtiles mtime seems to be removed Oct 6, 2024
@brendan-ward
Copy link
Collaborator

Looks like this got dropped quite some time ago; I don't have a clear memory as to why. It might have been part of migrating from having the handlers at the top level and handled by echo to moving them to the handlers package and handling via Go route handlers.

The timestamp of a tileset is still available as part of the MBtiles struct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants