Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip scanning opus files with existing headers output gain #128

Open
Tokariew opened this issue Sep 24, 2024 · 2 comments
Open

Comments

@Tokariew
Copy link

Currently if someone use opus in mode a or t opus file will be scanned in each subsequent run after the first even when used with -S output. Can we get some option to skip opus files with existing gain headers?
Tested with:

➜ rsgain --version
rsgain 3.5.1 - using:
   libebur128     1.2.6
   libavformat    60.16.100
   libavcodec     60.31.102
   libavutil      58.29.100
   libswresample  4.12.100

Built with:
   TagLib         1.12

Compiler:         GCC 14.1
Build Date:       2024-06-08
@complexlogic
Copy link
Owner

That's an interesting idea that I hadn't considered before. I suppose the downside of skipping files with an existing header gain is that it could have a 'false positive'. The header gain set by another program may not actually correspond to ReplayGain; it could have been set for some other purpose.

Then again, I would expect new users to scan their entire library when using rsgain for the first time. So, the 'false positive' issue may not actually be a significant problem at all.

I will have to give this some further thought.

@Tokariew
Copy link
Author

I was using r128gain in my podcast dowload and gain normalization and was thinking to switching to rsgain for it.

so i tested with firstly full run, and then hoping that -S option will provide option to skip scanned.
Not sure if it should be in existing -S option as header gain is not ReplaGain info.
And if it should work only in a or t mode for opus or for all modes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants