-
Notifications
You must be signed in to change notification settings - Fork 20
Use submodule for Codesign, don't include the sources. #45
Comments
Yes! |
Not sure, whether and how it can be done, but ideally you would always link/include the latest version. |
Latest tagged version or (how bleeding edge is |
What I was thinking about was to setup a submodule somewhere, e.g. The question is whether the dist folder is kept up-to-date or if the build script would have to run the SCSS compiler first. In that case #31 would be blocking this, because otherwise the install instructions and the project would get out of sync. (People would have to install a SCSS compiler.) |
@ranolfi |
I have this mostly completed in asynts/codidact-core:asynts/45/use-submodule-for-codesign, just need to test this (can't do this now). I'll create a pull request later. |
BTW Co-Design is now available on npm, which might simplify this a bit: (Source code) (Registry) |
Core is not using npm for anything else so far, right? Would you be able to make a NuGet package instead? That'd be the canonical way of managing dependencies for .NET projects and solutions. |
That would not be the canonical way of managing FRONTEND dependencies. NPM is advisable. Please don't do this. |
|
@ranolfi I was about to point out the same thing, then I found this: https://stackoverflow.com/q/57038463/8746648 I couldn't find an official source for this, but it seems like NuGet isn't meant for this. |
Interesting, it seems I stand corrected. Thanks, fellows. May I drop some additional references here for my future self? and... |
@ranolfi It would be really nice if it were possible to install npm with the NuGet package manager, however, that NuGet package you linked was last updated in 2015. It's too good to be true! |
I've put forward a request/suggestion for @luap42 to make the necessary adjustments to co-design so that annotated tags can be maintained from there in the form of The relevant steps are:
|
Currently, a copy of the Codesign implementation sits in
src/WebUI/wwwroot/lib/co-design
. This should be a submodule, or maybe asubtreeworktree?I'm on it.
The text was updated successfully, but these errors were encountered: