Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Latest commit

 

History

History
43 lines (35 loc) · 3.3 KB

CONTRIBUTING.md

File metadata and controls

43 lines (35 loc) · 3.3 KB

Contributing to Codidact

Contributions are very welcome! Codidact is an open, community-run project, and that means the code too.

What needs doing?

  • Bugs are reported here on GitHub. Have a look at the open issues tagged type: bug to find something that needs fixing.
  • Requests for features are first discussed on our forum to create consensus around their specification. Once consensus is built, a card will be added to our MVP GitHub project as a To Do item.

Once you've picked what you're going to work on, please leave a comment on the issue to indicate you're planning to work on it; this helps us reduce wasted effort. If there's not already an issue for the feature you want to work on, please create one. If you need time to work on an issue, that's absolutely fine, but please keep us updated with comments on the issue - if we don't hear from you for a few weeks, we may assume you've given up working on that issue and give it to someone else.

What's the workflow?

  • First, you need an issue to work under. Either assign yourself to an existing issue (or request it be assigned to you), or create a new issue and assign yourself to that.
  • Second, you can make your changes. If you have access to the repository, create a topic branch (please use the format art/40/add-bells-and-whistles, i.e. username/issue-number/brief-description) and make your changes there; if not, fork the repository and work in your fork.
  • Once you've made your changes, submit a pull request targeting the develop branch.

Keep in mind that status checks are required to pass and at least one approving review is required from the team before any pull request can be merged. If status checks don't pass, we won't be able to merge - there are no exceptions, so please fix the failures and commit again. You can always mark your pull request as [WIP] (for "Work In Progress") while you're still trying to make it work.

What standards are there?

We have code style and standards documents for each applicable language. Please make sure you follow these if possible; if there's a good reason why not, please document it in your code, add a linter exception, and let us know why in your pull request. Here they are:

When writing CSS, keep in mind that our design framework, Co-Design is available in Core, and should be used where possible. Avoid writing custom CSS if you can; favour using components and atomic classes from Co-Design.

We also have some guidelines for commit messages. Again, please follow these where possible, as they help us to keep a cohesive commit history and see how the project has developed.