Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include package information in the LinkML yaml for phenopackets.yaml #3

Open
sierra-moxon opened this issue May 12, 2022 · 1 comment

Comments

@sierra-moxon
Copy link

To convert to valid proto files, we need to include package designations in the header.

Something like:
https://github.com/phenopackets/phenopacket-schema/blob/master/src/main/proto/phenopackets/schema/v2/phenopackets.proto

package org.phenopackets.schema.v2;

import "phenopackets/schema/v2/core/base.proto";
import "phenopackets/schema/v2/core/biosample.proto";
import "phenopackets/schema/v2/core/disease.proto";
import "phenopackets/schema/v2/core/interpretation.proto";
import "phenopackets/schema/v2/core/individual.proto";
import "phenopackets/schema/v2/core/measurement.proto";
import "phenopackets/schema/v2/core/medical_action.proto";
import "phenopackets/schema/v2/core/meta_data.proto";
import "phenopackets/schema/v2/core/pedigree.proto";
import "phenopackets/schema/v2/core/phenotypic_feature.proto";

Can we include this somehow in the metadata in LinkML or can we get it from the schemaname somehow?

@sierra-moxon
Copy link
Author

sierra-moxon commented May 12, 2022

One giant proto file is doable, then you don't need the imports, but this would break downstream software that is dependent on independent proto files per domain.

Maybe we just need a click parameter in LinkML protogen to reflect the yaml files in the generated proto files, with imports according to yaml file imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant