Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for gamma and luminance levels to determine proper font colors based on user-defined background colors #173

Closed
tviegut opened this issue Oct 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@tviegut
Copy link
Contributor

tviegut commented Oct 19, 2024

During development of #172 additional testing of user-defined colors surfaced that when darker colors are selected, the default font #000000 is unreadable. This prevents color selection that would allow for a Dark Mode theme for example. The font color should be dynamically determined (either white or black) based upon the gamma and luminance levels for each particular selected background color (e.g. for a concrete class or an abstract class).

The threshold should be: luminance < 0.5 use #FFFFFF else use #000000

Finally, if time permits, this may be an opportunity to add a simple Dark Mode theme setting in CIMTool user preferences. Below is the sample we're aiming for:

image

@tviegut tviegut added the enhancement New feature or request label Oct 19, 2024
@tviegut tviegut self-assigned this Oct 19, 2024
@tviegut tviegut moved this to Backlog in CIMTool 2.3.0 Oct 19, 2024
@tviegut tviegut moved this from Backlog to Ready in CIMTool 2.3.0 Oct 19, 2024
@tviegut tviegut moved this from Ready to In progress in CIMTool 2.3.0 Oct 19, 2024
tviegut added a commit that referenced this issue Oct 23, 2024
tviegut added a commit that referenced this issue Oct 23, 2024
tviegut added a commit that referenced this issue Oct 23, 2024
tviegut added a commit that referenced this issue Oct 23, 2024
tviegut added a commit that referenced this issue Oct 23, 2024
@tviegut tviegut moved this from In progress to In review in CIMTool 2.3.0 Oct 30, 2024
@tviegut tviegut moved this from In review to Done in CIMTool 2.3.0 Oct 30, 2024
@tviegut tviegut closed this as completed by moving to Done in CIMTool 2.3.0 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant