-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reconnect button #9
Comments
Sometimes, the communication thread dies - e.g. when the network disconnects, or when invalid unicode characters appear in the output (why?). Make it possible to start a new thread instead, maybe even restart it automatically after it dies. |
hi choroba, with my limited understanding there is no need to 'reconnect': the logged in state remains true even after parse errors. During the usage of the previous version (but considerations seem to me still valid) I collected various failures. You proposed a try::tiny blocks around connection/parsing iirc. Here errors I received in the past (note that i always use MCE but i think this is unrelated): 1) connection errors:
and
2) parser and decode errors:
and
and
and
If I can help I'll be glad to contribute: maybe for the try::tiny stuffs as my unicode-fu is limited |
@LorenzoTa Thanks for the collection. Is a Hobo thread restarted automatically when it terminates? Perl threads aren't, so I need to start a new thread in the mentioned situation. |
I dont think Hobo restarts automatically. but there is marioroy for details |
Automatic restart of the worker thread was implemented in 61b89a0. |
After recent fixes, the restart should be less frequent. The correct solution would be to create two threads, one for GUI and one for LWP, and have the main thread restart the LWP worker when it dies. |
No description provided.
The text was updated successfully, but these errors were encountered: