You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm digging into react-motion, and I find using the word "style" in the API and documentation very confusing.
Let's start with the opening example from readme:
import {Motion, spring} from 'react-motion';
// In your render...
<Motion defaultStyle={{x: 0}} style={{x: spring(10)}}>
{value => <div>{value.x}</div>}
</Motion>
There is no styling animation here at all. And it takes time and frustration to figure out why this "style" doesn't style anything, has no relation to stylistic appearance, and still is called "style".
The way I see it, react-notion basically "springs" stuff, and the stuff does not have to be CSS styles. So there should be a better word for reflecting this purpose of the library (if I get the purpose right).
The same confusion applies to TransitionStyle objects and pretty much all the *style* names.
Maybe "motion" could be a better word, as it reflects the fact that <Motion />, <StaggeredMotion /> and <TransitionMotion /> take some static props and bring them to motion for their children. Any other suggestions are welcome.
I create this issue to see if someone else feels the same and consider renaming before the library reaches 1.0.
The text was updated successfully, but these errors were encountered:
I'm digging into
react-motion
, and I find using the word "style" in the API and documentation very confusing.Let's start with the opening example from readme:
There is no styling animation here at all. And it takes time and frustration to figure out why this "style" doesn't style anything, has no relation to stylistic appearance, and still is called "style".
The way I see it,
react-notion
basically "springs" stuff, and the stuff does not have to be CSS styles. So there should be a better word for reflecting this purpose of the library (if I get the purpose right).The same confusion applies to
TransitionStyle
objects and pretty much all the*style*
names.Maybe "motion" could be a better word, as it reflects the fact that
<Motion />
,<StaggeredMotion />
and<TransitionMotion />
take some static props and bring them to motion for their children. Any other suggestions are welcome.I create this issue to see if someone else feels the same and consider renaming before the library reaches 1.0.
The text was updated successfully, but these errors were encountered: