Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asciidoc and Markdown style guides? #373

Closed
erget opened this issue Jul 29, 2022 · 14 comments · Fixed by #392
Closed

Asciidoc and Markdown style guides? #373

erget opened this issue Jul 29, 2022 · 14 comments · Fixed by #392

Comments

@erget
Copy link
Member

erget commented Jul 29, 2022

It would be nice to have a style guide for the documents that we take care of. Perhaps a topic for the upcoming user meeting and even a hackathon? 🤔 I'll contribute if anybody else thinks this is a good idea.

As proposed in cf-convention/discuss#152 (comment)

@erget erget added the style label Jul 29, 2022
@erget erget self-assigned this Jul 29, 2022
@davidhassell
Copy link
Contributor

Great idea. Lets add that to teh existing scheduled hackathon: cf-convention/discuss#152 (comment)

@sadielbartholomew
Copy link
Member

sadielbartholomew commented Jul 29, 2022

I also agree, this could be very useful. Though I would recommend that we refer to an existing guide/standard, rather than writing our own (that may have been the intention anyway, not sure!). I am thinking a clear and concise (enough) page of style guidance such as the Google style guides, e.g. here for Markdown (though they don't seem to have anything covering Asciidoc), would work well. And to cater for specific rules we want for the CF case, e.g:

Putting each sentence on a single line would help get us there

we could emphasise our own items of guidance, such as this one, and otherwise say something like "and for general style please refer to and abide by <existing style guide>".

And if there are auto-formatting tools available that we can utilise, even better, though I have not head of one for Markdown, at least. We can do a survey to see if anything exists, of course.

@erget
Copy link
Member Author

erget commented Sep 13, 2022

For Asciidoc in #381 @dnowacki-usgs found this which at first blush looks good to me.

@erget
Copy link
Member Author

erget commented Sep 13, 2022

After agreeing on one we might need a separate task to implement it to start.

One element I could imagine is taking a look at the use of monotype - in 5.6.1 I just noticed that we have some places where attributes are in normal type, rather than monotype, and we'd likely improve readability by changing that.

@erget
Copy link
Member Author

erget commented Sep 13, 2022

Same in following chapters, e.g. In chapter 6 you've got some naked URLs.

@erget
Copy link
Member Author

erget commented Sep 13, 2022

And "fixed_angle_axis" in table F.1 has formatting issues - it's bolded, not monotyped.

@erget
Copy link
Member Author

erget commented Sep 13, 2022

Same thing with sweep_angle_axis...

@erget
Copy link
Member Author

erget commented Sep 13, 2022

H.3 - in the caption of the example we'd benefit from some monotyping.

@erget
Copy link
Member Author

erget commented Sep 13, 2022

Consistent number of linebreaks between paragraphs?

@erget
Copy link
Member Author

erget commented Sep 13, 2022

Eliminate trailing whitespace?

@erget erget removed their assignment Sep 13, 2022
@jesusff
Copy link
Contributor

jesusff commented Sep 13, 2022

The lack of monotypes at some places is due to a trailing space right before the ending mark.

Does it make sense to also try to stick to a single way of writing bold and monotype together? There is currently a mix of

**`bold monotype`**

and

`**bold monotype**`

A single way would ease automatic location of errors such as extra space.

@erget
Copy link
Member Author

erget commented Sep 13, 2022

Yes, I think that would make sense. How do you like the style guides posted above?

@davidhassell
Copy link
Contributor

I've had a brief look at both style guides, and they look fine to me. Thanks.

@jesusff
Copy link
Contributor

jesusff commented Sep 13, 2022

Yes, they look good. There are some TODO parts, though. E.g. here there is no decision on monotype:

https://asciidoctor.org/docs/asciidoc-recommended-practices/#literal-text

but I think for this specific matter we clearly went for backticks to represent them. There is no plus sign representation for monotypes in the whole document.

@erget erget moved this from Todo to In Progress in Housekeeping at 2022 workshop Sep 13, 2022
@erget erget linked a pull request Sep 13, 2022 that will close this issue
Repository owner moved this from In Progress to Done in Housekeeping at 2022 workshop Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants