Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndarray/xarray based Composite Key Checker #22

Open
DocOtak opened this issue Jan 4, 2022 · 1 comment
Open

ndarray/xarray based Composite Key Checker #22

DocOtak opened this issue Jan 4, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@DocOtak
Copy link
Member

DocOtak commented Jan 4, 2022

As part of the "fast" reader work, functions/methods are needed to directly check an xr.Dataset or potentially ndarrays for valid exchange coordinates. This include:

  • The variables of expocode, station, cast, sample are compatible numpy (or xarray) broadcasting.
  • After broadcasting, the elementwise concatenation of values of the above variables is either unique or empty.
  • Data (after broadcasting) exists only if and only if the above elementwise is not empty.

This will allow us to check arbitrary input netcdf files for CCHDO flavored CF/netCDF validity not just the ones created by this software.

@DocOtak DocOtak added the Blocker We cannot publish unless this is resolved label Jan 4, 2022
@DocOtak DocOtak added this to the Fast Reader milestone Jan 4, 2022
@DocOtak DocOtak self-assigned this Jan 4, 2022
@DocOtak
Copy link
Member Author

DocOtak commented Mar 16, 2022

This was not closed in #27 because, while that checks the keys while converting, we still need a checker function that tells us if the xr.Dataset is correct outside of the exchange conversion context.

@DocOtak DocOtak removed this from the Fast Reader milestone Oct 4, 2023
@DocOtak DocOtak added enhancement New feature or request and removed Blocker We cannot publish unless this is resolved labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant