Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for snacks.nvim #806

Closed
mikededo opened this issue Nov 20, 2024 · 3 comments · Fixed by #807
Closed

feat: add support for snacks.nvim #806

mikededo opened this issue Nov 20, 2024 · 3 comments · Fixed by #807
Labels
enhancement New feature or request

Comments

@mikededo
Copy link
Contributor

Is your feature request related to a problem? Please describe.

snacks.nvim is a new QoL plugin, used by default in LazyVim over a collection of separate plugins. Currently, the highlights provided by this plugin are not supported.

Describe the solution you'd like

To implement the highlight tokens specified in here

@mikededo mikededo added the enhancement New feature or request label Nov 20, 2024
@rkaminsk
Copy link

rkaminsk commented Nov 22, 2024

Hi, I would also like to see an integration here. Catppuccin does not play nice with snacks.notify because the borders of messages are set in italic, which looks ugly. My current workaround (for lazy.vim) is to patch some highlight groups:

return {
    "catppuccin/nvim",
    name = "catppuccin",
    priority = 1000,
    opts = {
      custom_highlights = function(colors)
        return {
          DiagnosticInfo = { style = {} },
          DiagnosticError = { style = {} },
          DiagnosticWarn = { style = {} },
        }
      end,
    },
  }

@mikededo
Copy link
Contributor Author

Hey @rkaminsk, could you check if what's been implemented in #807 would work as you expect?

@rkaminsk
Copy link

rkaminsk commented Nov 23, 2024

@mikededo, yes your PR works.

PS: the default indicator, which is also a |, set with bufferline.nvim is also set in italic. Since all my attempts to configure this properly failed, I simply set

highlight BufferlineIndicatorSelected gui=bold

at the end of my config. This is of course unrelated to snacks.nvim.

PPS: In case, someone wants to fix the bufferline in a slightly better way:

return {
  "akinsho/bufferline.nvim",
  after = "catppuccin",
  opts = {
    highlights = require("catppuccin.groups.integrations.bufferline").get({
      custom = {
        all = {
          indicator_visible = { style = { "bold" } },
          indicator_selected = { style = { "bold" } },
        },
      },
    }),
  },
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants