Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What error to return when SIM Swap info is technically not available for a particular phone number #166

Open
HuubAppelboom opened this issue Oct 30, 2024 · 1 comment

Comments

@HuubAppelboom
Copy link

We have some very rare cases (less than 1 in 10000) where we don't have a SIM Activation time stamp in our platform.
The mobile phone number is however valid, and belongs to KPN.

Currently we are returning a null value in stead of a time stamp in the reply body.

It may be better however to return an error code instead
(also to avoid confusion also when there is a limitation becuase of privacy reasons).

What is the error code to return in this case?

Should we use a 422 error with code NOT_SUPPORTED and message Service not supported for this phoneNumber ?

Or would it be better to provide a 204 error code (No Content) ??

Please advice what is best.

@bigludo7
Copy link
Collaborator

I had the case in one Orange implem for very specific number where we were not able to get any date (and no able to provide the check). For this case we use the 422 with NOT_SUPPORTED code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants