Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting the max_investment ends in infinite loop #37

Closed
btschwertfeger opened this issue Jan 8, 2025 · 1 comment · Fixed by #38
Closed

Hitting the max_investment ends in infinite loop #37

btschwertfeger opened this issue Jan 8, 2025 · 1 comment · Fixed by #38
Assignees
Labels
bug Something isn't working
Milestone

Comments

@btschwertfeger
Copy link
Owner

When the algorithm hits the max_investment and tries to place $n$ open buy orders, it requests the current balances from Kraken. This is done in place_new_buy_order function, which will then evaluate if the order can placed or not. The problem here is that the the check_n_open_buy_orders function will not exit the while loop, causing lots of requests to Kraken and ending in rate limit errors.

@btschwertfeger btschwertfeger added the bug Something isn't working label Jan 8, 2025
@btschwertfeger btschwertfeger added this to the Upcoming Release milestone Jan 8, 2025
@btschwertfeger btschwertfeger self-assigned this Jan 8, 2025
@btschwertfeger
Copy link
Owner Author

Closing as done in #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant