From 672b0934dc477f670c8c5b67f1d17bc86f5817e8 Mon Sep 17 00:00:00 2001 From: Steven Luscher Date: Fri, 28 Jun 2024 18:40:48 -0700 Subject: [PATCH] chore: Mergify now gently nudges folks who update RPC code to also update the Rust and JavaScript clients (#1904) --- .mergify.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.mergify.yml b/.mergify.yml index eaadb978adae43..23469b3f055882 100644 --- a/.mergify.yml +++ b/.mergify.yml @@ -168,6 +168,21 @@ pull_request_rules: into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. + - name: Reminder to update RPC clients for changes in `rpc/` + conditions: + - or: + - files~=^rpc/src/rpc\.rs$ + - files~=^rpc/src/rpc_pubsub\.rs$ + - files~=^rpc-client-api/src/.*\.rs$ + actions: + comment: + message: | + If this PR represents a change to the public RPC API: + + 1. Make sure it includes a complementary update to `rpc-client/` ([example](https://github.com/solana-labs/solana/pull/29558/files)) + 2. Open a follow-up PR to update the JavaScript client `@solana/web3.js` ([example](https://github.com/solana-labs/solana-web3.js/pull/2868/files)) + + Thank you for keeping the RPC clients in sync with the server API @{{author}}. commands_restrictions: # The author of copied PRs is the Mergify user.