diff --git a/GitTrends.UITests/Tests/RepositoriesTests.cs b/GitTrends.UITests/Tests/RepositoriesTests.cs index 77dde1567..d0ce79f42 100644 --- a/GitTrends.UITests/Tests/RepositoriesTests.cs +++ b/GitTrends.UITests/Tests/RepositoriesTests.cs @@ -39,7 +39,7 @@ public async Task VerifySortingOptions(SortingOption sortingOption) //Act RepositoryPage.SetSortingOption(sortingOption); - //Wait for RepositoryList to refresh + //Allow RepositoryList to update await Task.Delay(1000).ConfigureAwait(false); //Assert diff --git a/GitTrends/Pages/SettingsPage.cs b/GitTrends/Pages/SettingsPage.cs index aae5bbc5f..96ec136af 100644 --- a/GitTrends/Pages/SettingsPage.cs +++ b/GitTrends/Pages/SettingsPage.cs @@ -51,16 +51,14 @@ RelativeLayout CreateLayout(bool isPortraitOrientation) var trendsSettingsView = new TrendsChartSettingsView(_trendsChartSettingsService); var registerforNotificationsView = new RegisterForNotificationsView(); - var versionNumberText = #if AppStore - $"Version: {VersionTracking.CurrentVersion}"; + var versionNumberText = $"Version {VersionTracking.CurrentVersion}"; #elif RELEASE - $"Version: {VersionTracking.CurrentVersion} (Release)"; + var versionNumberText = $"Version {VersionTracking.CurrentVersion} (Release)"; #elif DEBUG - $"Version: {VersionTracking.CurrentVersion} (Debug)"; -#else - throw new NotSupportedException(); + var versionNumberText = $"Version {VersionTracking.CurrentVersion} (Debug)"; #endif + var createdByLabel = new Label { AutomationId = SettingsPageAutomationIds.CreatedByLabel, diff --git a/GitTrends/ViewModels/RepositoryViewModel.cs b/GitTrends/ViewModels/RepositoryViewModel.cs index f279767fe..d73598ef3 100644 --- a/GitTrends/ViewModels/RepositoryViewModel.cs +++ b/GitTrends/ViewModels/RepositoryViewModel.cs @@ -70,7 +70,7 @@ public IReadOnlyList VisibleRepositoryList public bool IsRefreshing { get => _isRefreshing; - set => SetProperty(ref _isRefreshing, value, () => MainThread.InvokeOnMainThreadAsync(() => OnPropertyChanged(nameof(IsNotRefreshing)))); + set => SetProperty(ref _isRefreshing, value, () => OnPropertyChanged(nameof(IsNotRefreshing))); } async Task ExecutePullToRefreshCommand(string repositoryOwner) @@ -95,9 +95,9 @@ async Task ExecutePullToRefreshCommand(string repositoryOwner) _repositoryDatabase.SaveRepository(retrievedRepositoriesWithViewsAndClonesData).SafeFireAndForget(); completedRepoitories.Add(retrievedRepositoriesWithViewsAndClonesData); - //Limit the VisibleRepositoryList Updates to avoid overworking the UI Thread + //Batch the VisibleRepositoryList Updates to avoid overworking the UI Thread if (!GitHubAuthenticationService.IsDemoUser - && completedRepoitories.Count > repositoriesPerFetch / 20) + && completedRepoitories.Count > repositoriesPerFetch / 5) { AddRepositoriesToCollection(completedRepoitories, _searchBarText); completedRepoitories.Clear();