Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Remove External App Prompt for some schemes #43065

Closed
3 of 5 tasks
Brandon-T opened this issue Dec 30, 2024 · 1 comment · Fixed by brave/brave-core#27099, brave/brave-core#27214 or brave/brave-core#27241
Closed
3 of 5 tasks

[iOS] - Remove External App Prompt for some schemes #43065

Brandon-T opened this issue Dec 30, 2024 · 1 comment · Fixed by brave/brave-core#27099, brave/brave-core#27214 or brave/brave-core#27241
Assignees
@Brandon-T
Labels
OS/iOS Fixes related to iOS browser functionality QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.75.x - Beta

Comments

@Brandon-T
Copy link

Description

For tel:, facetime:, facetime-audio: schemes, we should remove the external prompt because a system confirmation prompt will display right after anyway.

Steps to reproduce

  1. Visit tel:12345678
  2. Visit facetime:12345678
  3. Visit facetime-audio:12345678

Actual result

  • External app prompt with cancel, allow is shown.

Expected result

  • Should not show the prompt. It should show the system alert instead.

Reproduces how often

Easily reproduced

Brave version

  • All

Device/iOS version

  • All

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@Brandon-T Brandon-T added OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude labels Dec 30, 2024
@Brandon-T Brandon-T self-assigned this Dec 30, 2024
@Brandon-T Brandon-T mentioned this issue Dec 30, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.76.x - Nightly milestone Jan 9, 2025
@brave-builds brave-builds mentioned this issue Jan 9, 2025
Merged
7 tasks
This was referenced Jan 13, 2025
Merged
Closed
Merged
@kjozwiak
Copy link
Member

The above requires 1.75.161 or higher for 1.75.x verification 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brandon-T Brandon-T

Labels
OS/iOS Fixes related to iOS browser functionality QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.75.x - Beta
3 participants
@Brandon-T @kjozwiak @brave-builds