Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some users cannot scroll on the tabs bar on iOS #41562

Closed
5 tasks
Brave-Matt opened this issue Oct 10, 2024 · 4 comments · Fixed by brave/brave-core#27061
Closed
5 tasks

Some users cannot scroll on the tabs bar on iOS #41562

Brave-Matt opened this issue Oct 10, 2024 · 4 comments · Fixed by brave/brave-core#27061
Assignees
Milestone

Comments

@Brave-Matt
Copy link

Description

Users are reporting that when trying to swipe/scroll using the tab strip (not tab picker) on iOS devices does not work. When attempting to do so, the strip will jump back to the tab currently in focus and prevent you from seeing tabs further down the strip.

A Community user has shared a video of the behavior:
https://youtu.be/0B4T7qCwWZ8

The user who originally wrote the report states that this has been happening for some number of months for them.

Steps to reproduce

  1. Launch Brave on iOS
  2. Open several tabs such that you need to scroll down the strip to view them all
  3. Observe the tab strip jumping back to the in-focus tabs position

Actual result

Tab strip will not properly scroll down the line of tabs

Expected result

Tab strip should scroll responsively to the position the user desires.

Reproduces how often

Easily reproduced

Brave version

Version 1.69.1 (171)

Device/iOS version

iPadOS 18+
Reported devices:
iPhone 13
iPad mini 5

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

Original user report:
https://community.brave.com/t/scrolling-through-tabs-is-broken/571045

@Brave-Matt Brave-Matt added bug feature/tabs-bar feature/user-interface All UI related OS/iOS Fixes related to iOS browser functionality labels Oct 10, 2024
@kylehickinson kylehickinson changed the title Some users cannot scroll on the tab strip on iOS Some users cannot scroll on the tabs bar on iOS Oct 10, 2024
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Nov 22, 2024
@kylehickinson
Copy link
Collaborator

kylehickinson commented Nov 22, 2024

Noticed this locally and the reason was that BrowserViewController.viewDidLayoutSubviews is being called while scrolling the tabs bar, which then re-scrolls to the active tab due to a call here. This must be a new change in iOS 18 though because this change has been around for over a year (brave/brave-ios#8032)

After a few relaunches though it stopped happening

@andyk
Copy link

andyk commented Dec 14, 2024

Been noticing this behavior for weeks (maybe months?) too. Using iOS 18.1.1 (22B91) now, iPhone 14 Pro. Not sure if this is the right place to vote for issues (if not, feel free to delete this comment or I can)

@Rooster13
Copy link

Started noticing this on iPadOS recently too. I don’t use the device as frequently so it’s possible this has been happening for a while. Updated to iPadOS 18.2 last night. Tried crashing and restarting the app, tried rebooting the device.

@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18.2 using version 1.75 (142)

  • Verified the Steps to Reproduce in the issue:
    • Ensured tabs in tabs bar are clickable and moveable.
    • Tested in both orientations
    • Tested using Top Bar and Bottom Bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants