Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Only load purchase intent resource if the user has joined Brave Rewards and opted-in to notification ads #38498

Closed
tmancey opened this issue May 22, 2024 · 1 comment
Closed

[ads] Only load purchase intent resource if the user has joined Brave Rewards and opted-in to notification ads #38498

tmancey opened this issue May 22, 2024 · 1 comment
Assignees
@tmancey
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. dev-concern feature/ads OS/Desktop

Comments

@tmancey
Copy link
Contributor

tmancey commented May 22, 2024 •
edited
Loading

Description

Platforms

all

Description

Only load purchase intent resource if the user has joined Brave Rewards and opted-in to notification ads to improve performance. Currently we also load this resource for users who have not joined Brave Rewards and not opted-in to notification ads.
@tmancey tmancey mentioned this issue May 22, 2024
Closed
24 tasks
@tmancey tmancey removed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels May 28, 2024
@tmancey
Copy link
Contributor Author

tmancey commented May 28, 2024

Closing issue as will be resolved by #38505

@tmancey tmancey closed this as completed May 28, 2024
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
@tmancey tmancey self-assigned this Jul 8, 2024
@tmancey tmancey added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. dev-concern feature/ads OS/Desktop
Projects
Ads
Status: Done
Milestone
No milestone
1 participant
@tmancey