Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.3 doesn't work at all for a multisite setup #39

Open
huyz opened this issue Jun 15, 2011 · 1 comment
Open

3.1.3 doesn't work at all for a multisite setup #39

huyz opened this issue Jun 15, 2011 · 1 comment

Comments

@huyz
Copy link

huyz commented Jun 15, 2011

Right now, it looks like version 3.1.3 of the plugin cannot work for a multisite setup using WordPress 3.x (I'm using 3.0.5).

The plugin's multisite-handling code makes two mistakes:

  • It assumes that there's a simple API for setting the network-wide settings just as easily as it's done for the per-blog options. That API doesn't exist (yet). See http://wordpress.stackexchange.com/questions/18314/global-settings-page-for-multisite-plugin. The current code writes to the per-blog settings and then tries to read the network-wide settings. So now you know why saved keys (and other settings) will not be read back.
  • It tries to set/read all settings, whether network-wide or per-blog, using a single method (which as I described in the previous bullet point is broken). The plugin should use two separate methods depending on which settings page the admin is using: (a) read/write network-wide settings manually and (b) read/write per-bog settings using Settings API.

I've included a workaround at: http://wordpress.org/support/topic/doesnt-save-keys-for-wordpress-305

@huyz
Copy link
Author

huyz commented Jul 4, 2011

See workaround commit at #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant