Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaDictProperty forces ascii key #150

Open
dannyroberts opened this issue Nov 21, 2012 · 1 comment
Open

SchemaDictProperty forces ascii key #150

dannyroberts opened this issue Nov 21, 2012 · 1 comment

Comments

@dannyroberts
Copy link
Contributor

038ee17

It seems like instead of forcing to a str it should do a check such as

assert isinstance(index, basestring)

or explicitly converting ints if that was the purpose. Alternatively, we could change str to unicode and call it a day.

@benoitc
Copy link
Owner

benoitc commented Feb 9, 2013

i am adding ti to the list of changes for the python 3 release for now. str/unicode/bytes will be seriously reworked at that time. I think having an assert may be good at that point anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants