New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace in TR indicator produces wrong results #667

Closed

ozum opened this issue Apr 15, 2024 · 0 comments · Fixed by #666

Contributor

ozum commented Apr 15, 2024

Hi,

Related to #665, I checked the replace feature in the TR indicator. It is not working correctly, and test for replace is missing.

I created PR #666 to fix this issue and add related tests.

In light of this issue, it would be beneficial to check the general points below:

Test coverage was reporting 100%, even though test for replace = true is missing in TR.
Other indicators may need tests for replacement, too.

Best,

The text was updated successfully, but these errors were encountered:

bennycode linked a pull request

that will close this issue

fix replace feature in TR #666

Merged

ozum closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment