-
Notifications
You must be signed in to change notification settings - Fork 10
What are the TODOs that would improve this extension? #2
Comments
|
|
Regarding 2: Is there a way to change the URL of the PIP? If not the only way I can imagine is to call |
Probably the ideal solution here is for YouTube to update to not replace the video element when switching to a new video |
Btw I wanna ask is this Google's own official extension implementation? Also I hope that once we enabled those three, the extension package should be automatically installed, means it should be packed inside the Chrome Canary installations, and once restarted it should be now installed. So more users can now test this great feature |
Also here some of my implementations suggestions, not really a web dev, as a UX designer:
|
Also I just found out that indeed resizing player does exist now but it only exist on top right corner only for some reasons. I hope that you enable resizing of it in any sides, letterboxing the video if it's not on equal aspect ratio size (install this extension and app and try it on YouTube (only works on YouTube, see their implementation) and Shift + resizing it will resize it on constrained aspect ration size. Also I hope that you guys fix the buggy resizing UX, it clips the video and popup. Please fix it ASAP |
Using native pip on Windows/Mac would require a separate companion app |
@matthewdias I see as it is UWP only right. What if installing a discrete UWP companion app in Chrome installation in the future? That's how others circumvent APIs for UWP |
I'm not sure if it's UWP only, I was saying that based on the fact that this is an extension. If we're talking about what Chrome could have builtin, Mac could be easily supported, but idk about Windows. |
To be clear, this Chrome extension is not official. It is just a way for me to test the Picture-in-Picture Web API that I'm implementing in Chrome these days: https://chromium.googlesource.com/chromium/src/+log/master/[email protected] This API will allow websites (YouTube, Vimeo, Twitch, etc...) to add a Picture-in-Picture button to their media player if they opt-in. If you've enabled flags, you should see it. Give it a try at https://beaufortfrancois.github.io/sandbox/media/plain-video.html |
Regarding issues or bugs, I'd be very grateful if you report them at https://bugs.chromium.org/p/chromium/issues/entry?components=Blink%3EMedia%3EPictureInPicture For info, here's our updated implementation status page: https://github.com/WICG/picture-in-picture/blob/master/implementation-status.md |
I tested this extension on macOS. I understand that it's not an official implementation yet. Just wanted to point out some notes.
|
Thank you @vsg24 for your feedback! This extension uses the work-in-progress Picture-in-Picture feature in Chrome. The good news is that it will get better every day. You can see how much is being worked on these days at https://chromium-review.googlesource.com/dashboard/[email protected] In the mean time, please keep sending issues my way. @japacible @mounirlamouri Please have a look above at all valid issues raised by @vsg24. |
I see I thought is is Google's initiative to really work on PiP now on Chrome in any platform. I hope they fork your code here and continue it to be an official implementation |
1 similar comment
I see I thought is is Google's initiative to really work on PiP now on Chrome in any platform. I hope they fork your code here and continue it to be an official implementation |
I am thinking about extending the functionality of this extension, but I'm unsure what the TODOs are. Or if it's worth it (as this will get implemented native I guess?)
I'd say:
The text was updated successfully, but these errors were encountered: