Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

What are the TODOs that would improve this extension? #2

Open
kurtextrem opened this issue May 17, 2018 · 18 comments
Open

What are the TODOs that would improve this extension? #2

kurtextrem opened this issue May 17, 2018 · 18 comments

Comments

@kurtextrem
Copy link

I am thinking about extending the functionality of this extension, but I'm unsure what the TODOs are. Or if it's worth it (as this will get implemented native I guess?)

I'd say:

  • Context menu option when you right click the video
  • Automatically PIP the next video when auto play is enabled
  • Icon next to the cog or so
@beaufortfrancois
Copy link
Owner

Thanks for your interest!

  1. Video context menu is available but not working yet in Chrome. It will be fixed soon hopefully.

image

  1. Are you talking about YouTube "auto play" feature?

  2. I'm not sure what you mean there.

@kurtextrem
Copy link
Author

  1. Thanks!
  2. Yes. Also, as of the latest Chrome Dev the PIP even disappears when you skip an AD. Not really a user-friendly behavior.
  3. The YouTube player has a cog icon where you can set the quality and such. We could add an "PIP" icon next to it (so you can click there instead of the browser action).

@beaufortfrancois
Copy link
Owner

  1. I'm not sure how to do this reliably. Do you have a PR already in mind?

  2. Hopefully YouTube will a proper PiP icon in their player once PiP is stable. As you may have noticed, it is still pretty much experimental. You can follow along development at https://github.com/WICG/picture-in-picture/blob/master/implementation-status.md by the way.

@kurtextrem
Copy link
Author

Regarding 2: Is there a way to change the URL of the PIP? If not the only way I can imagine is to call .requestPictureInPicture() after a new video has loaded.

@matthewdias
Copy link

Probably the ideal solution here is for YouTube to update to not replace the video element when switching to a new video

@Mancerrss
Copy link

Btw I wanna ask is this Google's own official extension implementation? Also I hope that once we enabled those three, the extension package should be automatically installed, means it should be packed inside the Chrome Canary installations, and once restarted it should be now installed. So more users can now test this great feature

@Mancerrss
Copy link

Mancerrss commented May 20, 2018

Also here some of my implementations suggestions, not really a web dev, as a UX designer:

  1. Merge implementation to Windows 10's PiP implementation, or build above it?
  2. More controls in the PiP Window
  3. Ability to resize the window until 200% much bigger than it's OG launch size (priority)
  4. Hover controls dissapears in hover in split second (bug)
  5. Hope to just get the Website's web player, put in the popup and just resize it to be smaller, so each other's video player implementation and controls are preserved
  6. Or just immitate the controls UI of Android N's PiP feature
  7. Ability to add overlay subtitles above it, subtitles font size dynamically (to legible readable size) change as the video pop size changes
  8. Chrome stops overlaying the next video e.g. on autoplay or playlist like on YouTube, it get back on playing on the web page too, relaunching PiP thru extension button doesn't launch it again either
  9. Much smoother & sensible popup and resize animation, also I hope on fullscreen UX too, on any platform

@Mancerrss
Copy link

Also I just found out that indeed resizing player does exist now but it only exist on top right corner only for some reasons. I hope that you enable resizing of it in any sides, letterboxing the video if it's not on equal aspect ratio size (install this extension and app and try it on YouTube (only works on YouTube, see their implementation) and Shift + resizing it will resize it on constrained aspect ration size.

Also I hope that you guys fix the buggy resizing UX, it clips the video and popup. Please fix it ASAP

@matthewdias
Copy link

Using native pip on Windows/Mac would require a separate companion app

@Mancerrss
Copy link

@matthewdias I see as it is UWP only right. What if installing a discrete UWP companion app in Chrome installation in the future? That's how others circumvent APIs for UWP

@matthewdias
Copy link

I'm not sure if it's UWP only, I was saying that based on the fact that this is an extension. If we're talking about what Chrome could have builtin, Mac could be easily supported, but idk about Windows.

@beaufortfrancois
Copy link
Owner

To be clear, this Chrome extension is not official. It is just a way for me to test the Picture-in-Picture Web API that I'm implementing in Chrome these days: https://chromium.googlesource.com/chromium/src/+log/master/[email protected]

This API will allow websites (YouTube, Vimeo, Twitch, etc...) to add a Picture-in-Picture button to their media player if they opt-in.
Note that native video media controls will have a Picture-in-Picture button by default though . See screenshot below for an example of what it looks like.

image

If you've enabled flags, you should see it. Give it a try at https://beaufortfrancois.github.io/sandbox/media/plain-video.html

@beaufortfrancois
Copy link
Owner

Regarding issues or bugs, I'd be very grateful if you report them at https://bugs.chromium.org/p/chromium/issues/entry?components=Blink%3EMedia%3EPictureInPicture

For info, here's our updated implementation status page: https://github.com/WICG/picture-in-picture/blob/master/implementation-status.md

@beaufortfrancois
Copy link
Owner

FYI @mounirlamouri @japacible

@vsg24
Copy link

vsg24 commented May 24, 2018

I tested this extension on macOS. I understand that it's not an official implementation yet. Just wanted to point out some notes.
It's pretty bad compared to Safari.

  • Resizing doesn't work properly and often gets stuck outside of the screen area (video even freezes while doing so)
  • Video freezes completely when Chrome is minimized (Safari can continue working fine)
  • Safari has much better buttons on the PiP window.
  • Impossible to minimize PiP window to the side of the screen (macOS feature)

@beaufortfrancois
Copy link
Owner

Thank you @vsg24 for your feedback!

This extension uses the work-in-progress Picture-in-Picture feature in Chrome. The good news is that it will get better every day. You can see how much is being worked on these days at https://chromium-review.googlesource.com/dashboard/[email protected]

In the mean time, please keep sending issues my way.
The best way moving forward is to file a bug at https://bugs.chromium.org/p/chromium/issues/entry?components=Blink%3EMedia%3EPictureInPicture

@japacible @mounirlamouri Please have a look above at all valid issues raised by @vsg24.

@Mancerrss
Copy link

I see I thought is is Google's initiative to really work on PiP now on Chrome in any platform. I hope they fork your code here and continue it to be an official implementation

1 similar comment
@Mancerrss
Copy link

I see I thought is is Google's initiative to really work on PiP now on Chrome in any platform. I hope they fork your code here and continue it to be an official implementation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants