Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci.pull is too sensitive to credential helper failures #750

Open
thesayyn opened this issue Dec 12, 2024 · 0 comments
Open

oci.pull is too sensitive to credential helper failures #750

thesayyn opened this issue Dec 12, 2024 · 0 comments

Comments

@thesayyn
Copy link
Collaborator

Currently, if oci.pull fails when fetching credentials from credhelpers if the docker/config.json has a corresponding entry in auths dictionary.

EG:

{
  "auths": {
      "ghcr.io": {}
  },
  "credsStore": "desktop"
}

Even if oci.pull is pulling a public image, it tries to fetch credentials which will lead to failures since the credential helper has no credentials stored.

pattern = _fetch_auth_via_creds_helper(rctx, host_raw, config["credsStore"])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant