Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class structure #24

Open
peach-lucien opened this issue Mar 12, 2020 · 3 comments
Open

class structure #24

peach-lucien opened this issue Mar 12, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@peach-lucien
Copy link
Collaborator

For user experience, they will want to simply open a notebook and import a class and just import there data from there. I think that forcing them to use the command line with a custom dataset is going to cause a lot of problems. They will need to generate a pickle of their data in the correct manner (which they'll have to do in python), then they have to make sure everything is in the correct folders and then run it from the command line with some difficulty in getting commands correct.

I think we need to have a simple class they can import. From which we can return the feature results, analyse the feature results, and plot the feature results. Just return them and don't save them to the class object for memory purposes. This will provide much easier functionality for a user I believe. We only need one class - that of the hcga object.

@nrbernier
Copy link
Contributor

That's a good point. It does not have to replace the app.py commands. Since anyway the functions in app.py are simply wrappers for the relevant functions in other modules, there can be in the same way a hcga class that uses the same basic functions and just works from a list of graphs and labels.

@arnaudon
Copy link
Collaborator

I'll only work on the functions and app for now, but we we'll need to have hcga class aligned with the modifications.

@peach-lucien
Copy link
Collaborator Author

The class just needs some bugs with imports fixing at this point.

@arnaudon arnaudon added the bug Something isn't working label Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants