Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title Can Contain Newline Character #6149

Open
joncameron opened this issue Dec 16, 2024 · 1 comment
Open

Title Can Contain Newline Character #6149

joncameron opened this issue Dec 16, 2024 · 1 comment

Comments

@joncameron
Copy link
Contributor

Description

Should these be allowed? Is there anywhere we're respecting a newline within a title?

Example from Blacklight Solr

https://media.dlib.indiana.edu/media_objects/gt54kn18h

{"id"=>"gt54kn18h",
 "type"=>"MediaObject",
 "attributes"=>
  {"title"=>"Great Music with a Great Story:\nCurating Smithsonian Folkways Recordings",
   "title_tesi"=>
    {"id"=>"https://media.dlib.indiana.edu/media_objects/gt54kn18h#title_tesi",
     "type"=>"document_value",
     "attributes"=>{"value"=>"Great Music with a Great Story:\nCurating Smithsonian Folkways Recordings", "label"=>"Title"}},
   "date_issued_ssi"=>
    {"id"=>"https://media.dlib.indiana.edu/media_objects/gt54kn18h#date_issued_ssi",
     "type"=>"document_value",
     "attributes"=>{"value"=>"2014-10-07", "label"=>"Date"}},
   "creator_ssim"=>
    {"id"=>"https://media.dlib.indiana.edu/media_objects/gt54kn18h#creator_ssim",
     "type"=>"document_value",
     "attributes"=>{"value"=>"Sheehy, Daniel ", "label"=>"Main contributors"}},
   "abstract_ssi"=>
    {"id"=>"https://media.dlib.indiana.edu/media_objects/gt54kn18h#abstract_ssi",
     "type"=>"document_value",
     "attributes"=>{"value"=>nil, "label"=>"Summary"}},
   "duration_ssi"=>
    {"id"=>"https://media.dlib.indiana.edu/media_objects/gt54kn18h#duration_ssi",
     "type"=>"document_value",
     "attributes"=>{"value"=>"5500461", "label"=>"Duration"}},
   "section_id_ssim"=>
    {"id"=>"https://media.dlib.indiana.edu/media_objects/gt54kn18h#section_id_ssim",
     "type"=>"document_value",
     "attributes"=>{"value"=>["k930bz51h"], "label"=>"Sections"}}},
 "links"=>{"self"=>"https://media.dlib.indiana.edu/media_objects/gt54kn18h"}}
@joncameron
Copy link
Contributor Author

We can ignore for the moment: line breaks are allowed in IIIF and we're including '\n' in the generated manifest, so Avalon could be updated in the future to render the line break (this is in Avalon and not in Ramp).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant