From f0d950de3daffd7319f12a972a7bfa7c186cc1c8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 2 Apr 2024 07:07:54 +0000 Subject: [PATCH] Go Dependency: Bump github.com/vmware/govmomi from 0.36.2 to 0.36.3 Bumps [github.com/vmware/govmomi](https://github.com/vmware/govmomi) from 0.36.2 to 0.36.3. - [Release notes](https://github.com/vmware/govmomi/releases) - [Changelog](https://github.com/vmware/govmomi/blob/main/CHANGELOG.md) - [Commits](https://github.com/vmware/govmomi/compare/v0.36.2...v0.36.3) --- updated-dependencies: - dependency-name: github.com/vmware/govmomi dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- go.mod | 2 +- go.sum | 4 ++-- .../vmware/govmomi/internal/version/version.go | 2 +- vendor/github.com/vmware/govmomi/object/task.go | 14 ++++++++++++-- vendor/github.com/vmware/govmomi/property/wait.go | 4 ---- vendor/modules.txt | 2 +- 6 files changed, 17 insertions(+), 11 deletions(-) diff --git a/go.mod b/go.mod index 43d6f4a4..04d13bc9 100644 --- a/go.mod +++ b/go.mod @@ -13,7 +13,7 @@ require ( github.com/atc0005/go-nagios v0.16.1 github.com/google/go-cmp v0.6.0 github.com/rs/zerolog v1.32.0 - github.com/vmware/govmomi v0.36.2 + github.com/vmware/govmomi v0.36.3 ) require ( diff --git a/go.sum b/go.sum index b50ed34e..75e1c4e2 100644 --- a/go.sum +++ b/go.sum @@ -18,8 +18,8 @@ github.com/rs/xid v1.5.0/go.mod h1:trrq9SKmegXys3aeAKXMUTdJsYXVwGY3RLcfgqegfbg= github.com/rs/zerolog v1.32.0 h1:keLypqrlIjaFsbmJOBdB/qvyF8KEtCWHwobLp5l/mQ0= github.com/rs/zerolog v1.32.0/go.mod h1:/7mN4D5sKwJLZQ2b/znpjC3/GQWY/xaDXUM0kKWRHss= github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg= -github.com/vmware/govmomi v0.36.2 h1:fFTicZmjwPCiBJGyKLZ5Ty9JbTgBPVSXJDv1Duw0r7c= -github.com/vmware/govmomi v0.36.2/go.mod h1:mtGWtM+YhTADHlCgJBiskSRPOZRsN9MSjPzaZLte/oQ= +github.com/vmware/govmomi v0.36.3 h1:1Ng3CBNQVbFjCQbKtfsewy5o3dFa+EoTjqeThVISUBc= +github.com/vmware/govmomi v0.36.3/go.mod h1:mtGWtM+YhTADHlCgJBiskSRPOZRsN9MSjPzaZLte/oQ= golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.12.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= diff --git a/vendor/github.com/vmware/govmomi/internal/version/version.go b/vendor/github.com/vmware/govmomi/internal/version/version.go index 246e2ad3..e2d9fa86 100644 --- a/vendor/github.com/vmware/govmomi/internal/version/version.go +++ b/vendor/github.com/vmware/govmomi/internal/version/version.go @@ -21,5 +21,5 @@ const ( ClientName = "govmomi" // ClientVersion is the version of this SDK - ClientVersion = "0.36.2" + ClientVersion = "0.36.3" ) diff --git a/vendor/github.com/vmware/govmomi/object/task.go b/vendor/github.com/vmware/govmomi/object/task.go index 373407cc..583bcc6e 100644 --- a/vendor/github.com/vmware/govmomi/object/task.go +++ b/vendor/github.com/vmware/govmomi/object/task.go @@ -44,13 +44,17 @@ func NewTask(c *vim25.Client, ref types.ManagedObjectReference) *Task { return &t } -// Deprecated: Please use WaitEx instead. +// Wait waits for a task to complete. +// NOTE: This method create a thread-safe PropertyCollector instance per-call, so it is thread safe. +// The downside of this approach is the additional resource usage on the vCenter side for each call. func (t *Task) Wait(ctx context.Context) error { _, err := t.WaitForResult(ctx, nil) return err } -// Deprecated: Please use WaitForResultEx instead. +// WaitForResult wait for a task to complete. +// NOTE: This method create a thread-safe PropertyCollector instance per-call, so it is thread safe. +// The downside of this approach is the additional resource usage on the vCenter side for each call. func (t *Task) WaitForResult(ctx context.Context, s ...progress.Sinker) (taskInfo *types.TaskInfo, result error) { var pr progress.Sinker if len(s) == 1 { @@ -79,11 +83,17 @@ func (t *Task) WaitForResult(ctx context.Context, s ...progress.Sinker) (taskInf return task.WaitEx(ctx, t.Reference(), p, pr) } +// WaitEx waits for a task to complete. +// NOTE: This method use the same PropertyCollector instance in each call, thus reducing resource usage on the vCenter side. +// The downside of this approach is that this method is not thread safe. func (t *Task) WaitEx(ctx context.Context) error { _, err := t.WaitForResultEx(ctx, nil) return err } +// WaitForResultEx waits for a task to complete. +// NOTE: This method use the same PropertyCollector instance in each call, thus reducing resource usage on the vCenter side. +// The downside of this approach is that this method is not thread safe. func (t *Task) WaitForResultEx(ctx context.Context, s ...progress.Sinker) (*types.TaskInfo, error) { var pr progress.Sinker if len(s) == 1 { diff --git a/vendor/github.com/vmware/govmomi/property/wait.go b/vendor/github.com/vmware/govmomi/property/wait.go index 6b173afe..07ea3cb5 100644 --- a/vendor/github.com/vmware/govmomi/property/wait.go +++ b/vendor/github.com/vmware/govmomi/property/wait.go @@ -92,10 +92,6 @@ func Wait(ctx context.Context, c *Collector, obj types.ManagedObjectReference, p // By default, ObjectUpdate.MissingSet faults are not propagated to the returned // error, set WaitFilter.PropagateMissing=true to enable MissingSet fault // propagation. -// -// Deprecated: Please consider using WaitForUpdatesEx instead, as it does not -// create a new property collector, instead it destroys the property filter -// after the expected update is received. func WaitForUpdates( ctx context.Context, c *Collector, diff --git a/vendor/modules.txt b/vendor/modules.txt index 0316b943..e31522b3 100644 --- a/vendor/modules.txt +++ b/vendor/modules.txt @@ -20,7 +20,7 @@ github.com/rs/zerolog github.com/rs/zerolog/internal/cbor github.com/rs/zerolog/internal/json github.com/rs/zerolog/log -# github.com/vmware/govmomi v0.36.2 +# github.com/vmware/govmomi v0.36.3 ## explicit; go 1.19 github.com/vmware/govmomi github.com/vmware/govmomi/find