Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build process #110

Open
woodhull opened this issue Jan 20, 2025 · 1 comment
Open

CI build process #110

woodhull opened this issue Jan 20, 2025 · 1 comment

Comments

@woodhull
Copy link
Contributor

I ran the test suite locally and received the following output:

> maily@ test /Users/nathanwoodhull/work/maily.to
> turbo run test

turbo 2.3.3

• Packages in scope: @maily-to/core, @maily-to/render, tailwind-config, tsconfig, web
• Running test in 5 packages
• Remote caching disabled
@maily-to/render:test: cache miss, executing 119f7fd5970aa33c
@maily-to/render:test: 
@maily-to/render:test: 
@maily-to/render:test: > @maily-to/[email protected] test /Users/nathanwoodhull/work/maily.to/packages/render
@maily-to/render:test: > vitest run
@maily-to/render:test: 
@maily-to/render:test: The CJS build of Vite's Node API is deprecated. See https://vite.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
@maily-to/render:test: 
@maily-to/render:test:  RUN  v2.1.8 /Users/nathanwoodhull/work/maily.to/packages/render
@maily-to/render:test: 
 ❯ src/render.test.ts (7)
@maily-to/render:test:    ❯ render (7)
@maily-to/render:test:      ✓ should replace variables with values
@maily-to/render:test:      × should replace variables with default formatted value
@maily-to/render:test:      ✓ should replace variables formatter with custom formatter
@maily-to/render:test:      ✓ should replace variables with fallback value
@maily-to/render:test:      ✓ should replace links with setLinkValue value
@maily-to/render:test:      × should replace unsubscribe_url in button's href
@maily-to/render:test:      ✓ should apply custom theme
@maily-to/render:test: 
@maily-to/render:test: ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 2 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
@maily-to/render:test: 
@maily-to/render:test:  FAIL  src/render.test.ts > render > should replace variables with default formatted value
@maily-to/render:test: Error: Snapshot `render > should replace variables with default formatted value 1` mismatched
@maily-to/render:test: 
@maily-to/render:test: Expected: ""{{name,fallback=Buddy}}""
@maily-to/render:test: Received: ""Buddy""
@maily-to/render:test: 
@maily-to/render:test:  ❯ src/render.test.ts:53:20
@maily-to/render:test:      51|       plainText: true,
@maily-to/render:test:      52|     });
@maily-to/render:test:      53|     expect(result).toMatchInlineSnapshot(`"{{name,fallback=Buddy}}"`);
@maily-to/render:test:        |                    ^
@maily-to/render:test:      54|   });
@maily-to/render:test:      55| 
@maily-to/render:test: 
@maily-to/render:test: ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯
@maily-to/render:test: 
@maily-to/render:test:  FAIL  src/render.test.ts > render > should replace unsubscribe_url in button's href
@maily-to/render:test: Error: Snapshot `render > should replace unsubscribe_url in button's href 1` mismatched
@maily-to/render:test: 
@maily-to/render:test: Expected: ""Unsubscribe https://maily.to/unsubscribe_url""
@maily-to/render:test: Received: ""Unsubscribe unsubscribe_url""
@maily-to/render:test: 
@maily-to/render:test:  ❯ src/render.test.ts:185:20
@maily-to/render:test:     183|     });
@maily-to/render:test:     184| 
@maily-to/render:test:     185|     expect(result).toMatchInlineSnapshot(
@maily-to/render:test:        |                    ^
@maily-to/render:test:     186|       `"Unsubscribe https://maily.to/unsubscribe_url"`
@maily-to/render:test:     187|     );
@maily-to/render:test: 
@maily-to/render:test: ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/2]⎯
@maily-to/render:test: 
@maily-to/render:test:   Snapshots  2 failed
@maily-to/render:test:  Test Files  1 failed (1)
@maily-to/render:test:       Tests  2 failed | 5 passed (7)
@maily-to/render:test:    Start at  17:33:34
@maily-to/render:test:    Duration  774ms (transform 70ms, setup 0ms, collect 352ms, tests 39ms, environment 141ms, prepare 64ms)
@maily-to/render:test: 
@maily-to/render:test:  ELIFECYCLE  Test failed. See above for more details.
@maily-to/render:test: ERROR: command finished with error: command (/Users/nathanwoodhull/work/maily.to/packages/render) /Users/nathanwoodhull/Library/pnpm/pnpm run test exited (1)
@maily-to/render#test: command (/Users/nathanwoodhull/work/maily.to/packages/render) /Users/nathanwoodhull/Library/pnpm/pnpm run test exited (1)

 Tasks:    0 successful, 1 total
Cached:    0 cached, 1 total
  Time:    1.593s 
Failed:    @maily-to/render#test

 ERROR  run failed: command  exited (1)
 ELIFECYCLE  Test failed. See above for more details.

I'm not sure if this is expected or a result of the updates I made for my local copy to run cleanly in #109

Is there CI running anywhere? If I were to open a PR adding something (like Github Actions, or something that is free for open-source projects) do the project maintainers have a preference for which technology should be used.

A public CI could help collaborators know if the build failure they're seeing is specific to their environment, and would also speed up the feedback loop when problems are introduced.

@arikchakma
Copy link
Owner

I am aware of these issues, it's happening because of some breaking changes in the API. I will be fixing them in the next weekend. Thank you for opening the issue😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants