Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Invoke async should handle raw exception instead of CompletionException #9119

Open
3 tasks done
gaoyf opened this issue Jan 10, 2025 · 0 comments · May be fixed by #9120
Open
3 tasks done

[Bug] Invoke async should handle raw exception instead of CompletionException #9119

gaoyf opened this issue Jan 10, 2025 · 0 comments · May be fixed by #9120

Comments

@gaoyf
Copy link
Contributor

gaoyf commented Jan 10, 2025

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

OS: CentOS 6.9

RocketMQ version

branch: (develop|tag 5.3.1) version: 5.3.1

JDK Version

JDK: 1.8.0_202

Describe the Bug

NettyRemotingAbstract.invokeAsyncImpl should handle raw exception instead of CompletionException:
image

Because there are a lot of codes using raw exception for judging, such as: MQClientAPIImpl, DefaultMQPushConsumerImpl.

Steps to Reproduce

image
Raw exception will be wrap by CompletionException when execute future.completeExceptionally(exception).

What Did You Expect to See?

Raw exception.

What Did You See Instead?

Wrapped exception: CompletionException.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant