Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAddress on assertAccountsDecoded must be plural #49

Open
steveluscher opened this issue Jan 4, 2025 · 1 comment
Open

TAddress on assertAccountsDecoded must be plural #49

steveluscher opened this issue Jan 4, 2025 · 1 comment
Assignees
@lorisleiva
Labels
bug Something isn't working

Comments

@steveluscher
Copy link
Collaborator

The assertAccountsDecoded of @solana/addresses has a type parameter TAddress. This param is not plural, which implies that although assertAccountsDecoded operates over an array of addresses, the type parameter would enforce that every account has the same address.

Both TAddress and TData should probably be plural, and the return type should map over them to convert from something like Account<Uint8Array | TData[P], TAddress[P]> to Account<TData[P], TAddress[P]>
@steveluscher steveluscher added the bug Something isn't working label Jan 4, 2025
@steveluscher
Copy link
Collaborator Author

Also, if we have TypeDoc by the time you get to this, update the @typeParam TypeDoc.

@steveluscher steveluscher mentioned this issue Jan 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorisleiva lorisleiva

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveluscher @lorisleiva