Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE popups not working #72

Closed
nieldlr opened this issue Apr 9, 2013 · 3 comments
Closed

TinyMCE popups not working #72

nieldlr opened this issue Apr 9, 2013 · 3 comments

Comments

@nieldlr
Copy link

nieldlr commented Apr 9, 2013

Hey,

the TinyMCE directive is a bit of a mess at the moment. I'm still trying to solve this issue:
angular-ui/angular-ui-OLDREPO#475
(I'm getting around to it)

However, there's another error, which I'm sure should be fixed. At the moment Angular-UI gets the TinyMCE information via the fiddle urls:

<script src="http://fiddle.tinymce.com/tinymce/3.5.4.1/jquery.tinymce.js"></script>
<script src="http://fiddle.tinymce.com/tinymce/3.5.4.1/tiny_mce_jquery_src.js"></script>

However, when you want to create a url/anchor in TinyMCE the popup boxes do not work. You get this error in the console:

Unsafe JavaScript attempt to access frame with URL http://angular-ui.github.io/ from frame with URL http://fiddle.tinymce.com/tinymce/3.5.4.1/themes/advanced/link.htm. Domains, protocols and ports must match.

This can easily be solved by just self-hosting the files. I know, Angular-UI would not add these files to the build, but unsuspecting developers are unaware of this.

The docs should be updated explaining that you should host the files yourself and Angular-UI should change their demo site to self-host the files.

@ProLoser
Copy link
Member

ProLoser commented Apr 9, 2013

This is common across all projects. It's generally known practice that demo sites should not be relied upon for reliable asset hosting. Even Github will throttle requests to assets on their demo pages if you are not requesting from the Github domain itself.

Anyway, if you would like we are looking to add more people to the AngularUI team to help champion the individual repos. Keep in mind that we are reorganizing AngularUI and would like to relocate development of this specific directive to here: https://github.com/angular-ui/ui-tinymce

If you would be interested in helping us out with this module it would be awesome!

@nieldlr
Copy link
Author

nieldlr commented Apr 9, 2013

Hey ProLoser,

I see yes. I would love to work on the TinyMCE directive, as I'll probably be using it quite a lot in the future for my personal projects. At the moment I'm a bit swamped with coding work, but I'll definitely be keeping an eye/contributing when I can.

@ProLoser
Copy link
Member

Closing. Will have to be dealt with on the official repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants