You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The comment about key format on ServiceInfo constrcutor and field GROUP_POSITION is error.
In the ServiceInfo#getKey(name, clusters) method, it use @@ to concat name and clusters. because the name format is groupName@@serviceName, so the complete key format should be groupName@@name@@clusters.
publicclassServiceInfo {
// the error comment/** * file name pattern: groupName@@name@clusters. */privatestaticfinalintGROUP_POSITION = 0;
//...// the error comment/** * There is only one form of the key:groupName@@name@clusters. */publicServiceInfo(finalStringkey) {
// ...
}
publicstaticStringgetKey(Stringname, Stringclusters) {
if (!isEmpty(clusters)) {
// the name format is groupName@@serviceName// the complete format is groupName@@serviceName@@clustersreturnname + Constants.SERVICE_INFO_SPLITER + clusters;
}
returnname;
}
//...
}
Expected behavior
The descriptor of the key format is correct, it should be groupName@@name@@clusters
Actually behavior
The descriptor of the key format is incorrect, it is groupName@@name@clusters
How to Reproduce
Desktop (please complete the following information):
Branch [develop]
Module [naming/api]
Additional context
The text was updated successfully, but these errors were encountered:
mawen12
changed the title
fix comment typo on ServiceInfo(key) constructor
fix comment typo on ServiceInfo
Jan 8, 2025
Describe the bug
The comment about key format on ServiceInfo constrcutor and field
GROUP_POSITION
is error.In the
ServiceInfo#getKey(name, clusters)
method, it use@@
to concat name and clusters. because the name format isgroupName@@serviceName
, so the complete key format should begroupName@@name@@clusters
.Expected behavior
The descriptor of the key format is correct, it should be
groupName@@name@@clusters
Actually behavior
The descriptor of the key format is incorrect, it is
groupName@@name@clusters
How to Reproduce
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: