Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portability tests for wheels (in addition to existing binary portability tests) #576

Open
aorumbayev opened this issue Sep 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@aorumbayev
Copy link
Collaborator

Problem

CI currently can ignore errors with transitive dependencies that are referenced in the codebase, not pinned in pyproject but available in the lockfile. Given that all our workflows install dev and non dev deps on poetry install it won't catch such errors.

Solution

Add a few extra minor tests along with the portability tests for binaries which will install algokit cli from a fresh wheel in CI and then run portability tests on that cli (in an environments without dependencies installed from project's pyproject.toml)

Pros and Cons

Pros:

  • More thorough and robust CI that helps us catch obscure errors faster

Cons:

  • Slight increase in total time for each pipeline to run
@aorumbayev aorumbayev added the enhancement New feature or request label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant