Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the vue starter template so the window icon works on Windows and all oses by default #663

Open
4 tasks done
delebash opened this issue Nov 16, 2024 · 1 comment
Open
4 tasks done
Labels
enhancement New feature or request

Comments

@delebash
Copy link

Clear and concise description of the problem

Currently for main process in new BrowserWindow the icon is set as ...(process.platform === 'linux' ? { icon } : {}). The template already has a line to import an icon import icon from '../../resources/icon.png?asset'. For windows users the icon is not displayed on the new window because it is looking for linux.

Suggested solution

I just changed that line to icon:icon and it worked fine. Maybe other logic is needed for the different oses I am not sure. But the icon should work out of the box for all oses..

Alternative

No response

Additional context

No response

Validations

@delebash delebash added the enhancement New feature or request label Nov 16, 2024
@ggfong
Copy link

ggfong commented Nov 20, 2024

Windows platform icons use the icon format, while Linux uses the png format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants