Brush does not detect mouse up when releasing outside Bar element

[maryschmidt]

Hey, thanks for adding the Brush tool!

When creating a BrushSelection, the mouseUp event is not detected outside of the Bar. I would suggest adding a mouseUp event on the DOM and if dragging is true, behave like mouseUp happened on the Bar.

[williaster]

Hey @maryschmidt 👋 thanks for checking out vx! I agree proper detection of a mouseUp/onTouchEnd event would improve the UX of the component (which I would say is still very much a v0).

I likely will not have the bandwidth to add this feature very soon as I'm focusing on improved docs and other v1 efforts, but I would be happy to review a PR if you / anyone is interested in adding it!

[maryschmidt]

#618 If you can take a look at my PR

[joearasin]

@williaster It looks like in #667 the window event listeners added in #618 were removed. Was that intentional?

[williaster]

@joearasin yes, unfortunately when I actually tested the changes made in #618 , they did not work and so I removed them when also fixing the initialBrushPosition logic (which is what #618 turned into). So, still need a working solution for this issue.

I left a comment in #667 to document why they were removed.

[hshoff]

Was fixed in #1164 which added a useWindowMoveEvents boolean prop