Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ’get_redis_client #650

Open
Daihecyy opened this issue Jan 6, 2025 · 0 comments
Open

Improve ’get_redis_client #650

Daihecyy opened this issue Jan 6, 2025 · 0 comments
Labels
code quality enhancement New feature or request

Comments

@Daihecyy
Copy link
Contributor

Daihecyy commented Jan 6, 2025

The current get_redis_client function is doing some pretty ugly stuff in app/dependencies.py.
The following types shows that something is wrong :

redis_client: redis.Redis | bool | None = None

Consider splitting the variable redis_client into redis_client and redis_status.
@Daihecyy Daihecyy added enhancement New feature or request code quality labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Daihecyy