-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support v3 etcd api #13
Comments
@raoofm Sorry about reply so late, I just get more time to do this. What do you think about this? Do you have any good idea? I want to first implement all key-value interfaces. |
I'll take a look at what you have. I'll be interested in this, if you need any help implementing. I see a v3 branch will check that. |
@raoofm I just add some init commits in v3 branch, this is far from complete, I want to keep this step by step and I will focus on this this week. Really appreciate your help if you have time. Thanks very much :) |
@raoofm I am thinking about some implementation details, and I want to make this a good start. There are two proposals I have got:
Proposal2
I think proposal1 is more straightforward, we are constructing a huge client, the code snippet could be very long. Proposal2 divides these services to different sub-client, and we can implement services step by step. so what do you think? |
As of now Proposal2 seems to be a good starting point... I was just thinking loudly that how big would it be to change from proposal 2 to proposal 1 later. I think you earlier mentioned to wrap up the kv impl first, so proposal2 sounds good. What say? |
@raoofm as of now, etcd v3 has six kind of services: |
@adohe makes sense |
Support v3 etcd api https://github.com/coreos/etcd/blob/master/Documentation/dev-guide/api_reference_v3.md
The text was updated successfully, but these errors were encountered: