Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Jest Tests #63

Open
2 of 7 tasks
acrosman opened this issue Jul 24, 2021 · 2 comments
Open
2 of 7 tasks

Extend Jest Tests #63

acrosman opened this issue Jul 24, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed testing Related to automated testing

Comments

@acrosman
Copy link
Owner

acrosman commented Jul 24, 2021

Summary
With the merge of #49 which closed #48, we now have some test coverage. Bu there is only a little test coverage at the moment. Over time we'll work toward more.

This issue is for generally reminding of the need to include more tests. Additional sub-issues and related issues will be added for specific requests. If you'd like to add tests generically, you may want to look at the functions in src/sf_calls.js and src/preferences.js that do not callback to the main window directly (the project already includes rewire to make it easy to access non-exported features of the modules).

There are also no tests currently covering the render JS files, which are fairly extensive as well.

Specific Testing Issues

@acrosman acrosman added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers testing Related to automated testing labels Jul 24, 2021
@acrosman acrosman mentioned this issue Jul 24, 2021
@imrishabh18
Copy link
Contributor

imrishabh18 commented Jul 26, 2021

I have started to learn jest and wanted to contribute to some open source projects. What do you think would be best to start with here @acrosman ?

@acrosman
Copy link
Owner Author

Any one of:

All three have a pattern to review from other tests so you aren't starting totally from scratch. The last one is a bit more of a free space to run since it involves starting a whole new test file and the least figuring out how existing code works. The first two have clearer patterns to follow, but also require reading and understanding the code you're testing more deeply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed testing Related to automated testing
Projects
None yet
Development

No branches or pull requests

2 participants