-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated SQL Tab UI Enhancement #101
Comments
Theoretically some of the detail from #102 could be moved out into the main UI, Run SQL - Drop Existing or Run SQL - Create New Only |
Related to #107, which also overhauls this step. |
PR #120 updates to labels on the elements mentioned to be clearer. Adding a button to preview the SQL is an interesting idea, but runs into a few issues:
I am leaving this open for future thoughts and ideas. Others are welcome to offer PRs to take this further. |
Summary
Change the "Generated SQL" tab to Preview | Run | Save
Please describe the problem you are trying to solve.
Generate SQL, to me, means "write out the SQL".
Save SQL, to me, means "save the SQL for later".
Neither of them, to me, mean "execute the SQL on a database I'm going to tell you about".
Proposed Solution
I'd love to see three buttons here:
The text was updated successfully, but these errors were encountered: