diff --git a/.github/workflows/test_pr.yml b/.github/workflows/test_pr.yml index 6221455..6567c6a 100644 --- a/.github/workflows/test_pr.yml +++ b/.github/workflows/test_pr.yml @@ -4,7 +4,7 @@ on: push: branches: - main - pull_request_target: + pull_request: # FIXME (aliddell) branches: - main diff --git a/tests/test_basic.py b/tests/test_basic.py index 6abfa6d..d00c1f2 100644 --- a/tests/test_basic.py +++ b/tests/test_basic.py @@ -811,10 +811,6 @@ def test_simulated_camera_capabilities( assert camera.triggers.frame_start == (1, 0) -@pytest.mark.skip( - reason="Storage metadata is broken. See " - "https://github.com/acquire-project/acquire-video-runtime/issues/119" -) @pytest.mark.parametrize( ("descriptor", "chunking", "sharding", "multiscale"), [ @@ -836,6 +832,7 @@ def test_simulated_camera_capabilities( ) def test_storage_capabilities( runtime: Runtime, + request: pytest.FixtureRequest, descriptor: str, chunking: Optional[Dict[str, Any]], sharding: Optional[Dict[str, Any]], @@ -845,10 +842,21 @@ def test_storage_capabilities( p = runtime.get_configuration() p.video[0].camera.identifier = dm.select(DeviceKind.Camera, ".*empty") p.video[0].storage.identifier = dm.select(DeviceKind.Storage, descriptor) - p.video[0].storage.settings.filename = "out" + + # FIXME (aliddell): hack to get the storage capabilities to be populated + p.video[0].storage.settings.filename = f"{request.node.name}.out" + + p.video[0].storage.settings.external_metadata_json = json.dumps( + {"hello": "world"} + ) # for tiff-json + p.video[0].max_frame_count = 1000 runtime.set_configuration(p) + # FIXME (aliddell): hack to get the storage capabilities to be populated + runtime.start() c = runtime.get_capabilities() + # FIXME (aliddell): hack to get the storage capabilities to be populated + runtime.abort() storage = c.video[0].storage assert (