From 86ccc511517ee18d0e602ed33daa48b704fd3879 Mon Sep 17 00:00:00 2001
From: karrakoliko <github@karrakoliko.lol>
Date: Mon, 8 Apr 2024 18:26:50 +0700
Subject: [PATCH] fix: using href="#*" spams browser history

---
 src/Resources/views/bootstrap_3_layout.html.twig | 4 ++--
 src/Resources/views/bootstrap_4_layout.html.twig | 4 ++--
 src/Resources/views/bootstrap_5_layout.html.twig | 4 ++--
 src/Resources/views/macros.html.twig             | 4 ++--
 src/Resources/views/macros_bootstrap_3.html.twig | 4 ++--
 src/Resources/views/macros_bootstrap_4.html.twig | 4 ++--
 src/Resources/views/macros_bootstrap_5.html.twig | 4 ++--
 7 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/Resources/views/bootstrap_3_layout.html.twig b/src/Resources/views/bootstrap_3_layout.html.twig
index 27af08d..88cc310 100644
--- a/src/Resources/views/bootstrap_3_layout.html.twig
+++ b/src/Resources/views/bootstrap_3_layout.html.twig
@@ -7,11 +7,11 @@
                 {% set locale = translationsFields.vars.name %}
 
                 <li{% if app.request.locale == locale %} class="active"{% endif %}>
-                    <a href="#{{ translationsFields.vars.id }}_a2lix_translations-fields" data-toggle="tab" role="tab">
+                    <div data-bs-target="#{{ translationsFields.vars.id }}_a2lix_translations-fields" data-toggle="tab" role="tab">
                         {{ translationsFields.vars.label|default(locale|humanize)|trans }}
                         {% if form.vars.default_locale == locale %}{{ '[Default]'|trans }}{% endif %}
                         {% if translationsFields.vars.required %}*{% endif %}
-                    </a>
+                    </div>
                 </li>
             {% endfor %}
         </ul>
diff --git a/src/Resources/views/bootstrap_4_layout.html.twig b/src/Resources/views/bootstrap_4_layout.html.twig
index 960296d..9df3643 100644
--- a/src/Resources/views/bootstrap_4_layout.html.twig
+++ b/src/Resources/views/bootstrap_4_layout.html.twig
@@ -7,11 +7,11 @@
             {% set locale = translationsFields.vars.name %}
 
             <li class="nav-item">
-                <a href="#{{ translationsFields.vars.id }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-toggle="tab" role="tab">
+                <div data-bs-target="#{{ translationsFields.vars.id }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-toggle="tab" role="tab">
                     {{ translationsFields.vars.label|default(locale|humanize)|trans }}
                     {% if form.vars.default_locale == locale %}{{ '[Default]'|trans }}{% endif %}
                     {% if translationsFields.vars.required %}*{% endif %}
-                </a>
+                </div>
             </li>
         {% endfor %}
         </ul>
diff --git a/src/Resources/views/bootstrap_5_layout.html.twig b/src/Resources/views/bootstrap_5_layout.html.twig
index 946dc61..13d5e62 100644
--- a/src/Resources/views/bootstrap_5_layout.html.twig
+++ b/src/Resources/views/bootstrap_5_layout.html.twig
@@ -7,11 +7,11 @@
             {% set locale = translationsFields.vars.name %}
 
             <li class="nav-item">
-                <a href="#{{ translationsFields.vars.id }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-bs-toggle="tab" role="tab">
+                <div data-bs-target="#{{ translationsFields.vars.id }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-bs-toggle="tab" role="tab">
                     {{ translationsFields.vars.label|default(locale|humanize)|trans }}
                     {% if form.vars.default_locale == locale %}{{ '[Default]'|trans }}{% endif %}
                     {% if translationsFields.vars.required %}*{% endif %}
-                </a>
+                </div>
             </li>
         {% endfor %}
         </ul>
diff --git a/src/Resources/views/macros.html.twig b/src/Resources/views/macros.html.twig
index 93190c3..a4e5304 100644
--- a/src/Resources/views/macros.html.twig
+++ b/src/Resources/views/macros.html.twig
@@ -16,11 +16,11 @@ Example:
             {% set locale = translationsFields.vars.name %}
 
             <li class="nav-item">
-                <a href="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-toggle="tab" role="tab">
+                <div data-bs-target="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-toggle="tab" role="tab">
                     {{ translationsFields.vars.label|default(locale|humanize)|trans }}
                     {% if form.vars.default_locale == locale %}{{ '[Default]'|trans }}{% endif %}
                     {% if translationsFields.vars.required %}*{% endif %}
-                </a>
+                </div>
             </li>
         {% endfor %}
         </ul>
diff --git a/src/Resources/views/macros_bootstrap_3.html.twig b/src/Resources/views/macros_bootstrap_3.html.twig
index d1dd5f2..ec14ae6 100644
--- a/src/Resources/views/macros_bootstrap_3.html.twig
+++ b/src/Resources/views/macros_bootstrap_3.html.twig
@@ -14,11 +14,11 @@ Example:
                 {% set locale = translationsFields.vars.name %}
 
                 <li{% if app.request.locale == locale %} class="active"{% endif %}>
-                    <a href="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" data-toggle="tab" role="tab">
+                    <div data-bs-target="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" data-toggle="tab" role="tab">
                         {{ translationsFields.vars.label|default(locale|humanize)|trans }}
                         {% if form.vars.default_locale == locale %}{{ '[Default]'|trans }}{% endif %}
                         {% if translationsFields.vars.required %}*{% endif %}
-                    </a>
+                    </div>
                 </li>
             {% endfor %}
         </ul>
diff --git a/src/Resources/views/macros_bootstrap_4.html.twig b/src/Resources/views/macros_bootstrap_4.html.twig
index 10df8de..8fd7f20 100644
--- a/src/Resources/views/macros_bootstrap_4.html.twig
+++ b/src/Resources/views/macros_bootstrap_4.html.twig
@@ -14,11 +14,11 @@ Example:
                 {% set locale = translationsFields.vars.name %}
 
                 <li class="nav-item">
-                    <a href="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-toggle="tab" role="tab">
+                    <div data-bs-target="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-toggle="tab" role="tab">
                         {{ translationsFields.vars.label|default(locale|humanize)|trans }}
                         {% if form.vars.default_locale == locale %}{{ '[Default]'|trans }}{% endif %}
                         {% if translationsFields.vars.required %}*{% endif %}
-                    </a>
+                    </div>
                 </li>
             {% endfor %}
         </ul>
diff --git a/src/Resources/views/macros_bootstrap_5.html.twig b/src/Resources/views/macros_bootstrap_5.html.twig
index 794499c..ac0c822 100644
--- a/src/Resources/views/macros_bootstrap_5.html.twig
+++ b/src/Resources/views/macros_bootstrap_5.html.twig
@@ -14,11 +14,11 @@ Example:
                 {% set locale = translationsFields.vars.name %}
 
                 <li class="nav-item">
-                    <a href="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-bs-toggle="tab" role="tab">
+                    <div data-bs-target="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-bs-toggle="tab" role="tab">
                         {{ translationsFields.vars.label|default(locale|humanize)|trans }}
                         {% if form.vars.default_locale == locale %}{{ '[Default]'|trans }}{% endif %}
                         {% if translationsFields.vars.required %}*{% endif %}
-                    </a>
+                    </div>
                 </li>
             {% endfor %}
         </ul>