-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCP Profiles (Standard, Applications) specific checks / error levels #194
Comments
Just some thoughts on this issue. I think of it more in terms of, the QC solution I have. I would prefer to store a full library or checks, then allow the user to see results against all or a selected profile the DCP is targeting. negating the need to run multi check passes. Just an idea as implementation wise this could be major rewrite. |
A related question is how granular the checks should be? Right now related checks are sometimes bundled togehter in the same function. |
Yes agreed @jamiegau it would be nice to check how the DCP fares with the different profiles in one go. That is something to keep in mind and should be relatively straightforward with the current implementation. We need to find a good balance in check granularity, I agree that some checks could be more atomic. The more granular, the more control you have on the error report levels, but that can come at the price of code duplication / less performant code. Ideally the design goal would be to be as granular as possible... Sometime I wish be had a way of defining the specs / checks in a higher level language, like XSD schema, and generate code automatically from that... |
Maybe not totaly related, but it would be interesting to also explore property based testing with e.g. Hypothesis. |
We now have a way to check a DCP against multiple profiles without having to go through the whole test suite every time to save processing time. The only thing now would be to produce those different profiles. |
Hi Remi, I would like to puth this forward to ISDCF proponents and ask them to potentially create the profiles for addition to the repo.. And see if we get any input. For example, maybe a profile from deluxe (or multiple) based on purpose. Give the propellerheads in the group something to do and helpful in contribution to the project. |
ClairMeta is used to check different DCP (Interop, SMPTE) in various context (Mastering, Distribution, Preservation, ...).
The requirements are not the same in all case and we need to adjust the checks performed, eg. an Interop DCP from early 2010 ingested for preservation would not be expected to strictly follow RDD 52 recommendation. At the same time, it can be useful to have access to these new checks to detect potential issues on existing DCPs.
We already provide the check profile functionality that allow per check error level specification, one idea from @matmat would be to allow per standard error levels. To go further we could imagine a concept of DCP profiles (IOP, SMPTE, SMPTE B2.1, ...) and potentially user defined ones with each their own overload default error levels. The default check profile would probably be the more strict version (eg. SMPTE B2.1 RDD52) and others could be progressively more lenient.
ClairMeta could select the profile to use automatically or from user override.
This was discussed recently for checks related to picture resolution #184 subtitles font #178.
What are your thoughts on this ?
The text was updated successfully, but these errors were encountered: