You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Introduced in 25a6d3e:
Where Contacts([Contact(...)]) would before create a Contacts instance with a single Contact, it now assigns that list to pagination...
That's a breaking change that's hard for consumers to track.
Changing ordering of signature params like this is a surefire recipe for disaster:
https://github.com/XeroAPI/xero-python/blame/master/xero_python/accounting/models/contacts.py#L36
Introduced in 25a6d3e:
Where
Contacts([Contact(...)])
would before create aContacts
instance with a singleContact
, it now assigns that list topagination
...That's a breaking change that's hard for consumers to track.
Recommendation: disallow positional params, require kwargs only:
->
The text was updated successfully, but these errors were encountered: