Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError: PayrollNZ Read (all) Emp Salary & Wages #42

Open
ChocolateyShatner opened this issue Jun 8, 2022 · 3 comments
Open

ValueError: PayrollNZ Read (all) Emp Salary & Wages #42

ChocolateyShatner opened this issue Jun 8, 2022 · 3 comments

Comments

@ChocolateyShatner
Copy link

Hi,
I have cloned this repo, and trying to Read (all) Emp Salary & Wages from PayrollNZ.

Its coming up as an Internal Server Error and the terminal shows

ValueError: Invalid value for annual_salary, must not be None

I have not made any changes, is there anything I need to do?
I can access other PayrollNZ information as well as accounting info. But Salary and wages is what I really need.

Any help would be very much appreciated,
CS

@leegough
Copy link
Contributor

Hey @ChocolateyShatner thank you for raising the issue. Can I ask whether you are you using demo company or real world data to arrive at the error?

@ChocolateyShatner
Copy link
Author

Hi,
I am using the DemoCompany. Seems that when I comment out the code in the class that generated the ValueError, the Read (all) Emp Salary & Wages call now works fine.
Might this cause issues later?

@RettBehrens
Copy link
Contributor

Digging into this and it seems that the demo company has an hourly employee with the annual salary field set to null in the API response. Will need to check with the API team whether that should be a number even if the number is 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants