Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map: Add style variations #505

Closed
iandunn opened this issue Nov 15, 2023 · 0 comments · Fixed by #512
Closed

Map: Add style variations #505

iandunn opened this issue Nov 15, 2023 · 0 comments · Fixed by #512
Assignees

Comments

@iandunn
Copy link
Member

iandunn commented Nov 15, 2023

#504 introduced a last-minute change of the marker icon color. In the near future we'll need to support different icon colors on different pages, and also different styles. We should revert that PR and refactor to a more proper long-term solution. We shouldn't have to add new SVG files just to change the color. There should be block attributes to change the color, size, etc.

We may also want to support different images, but that is probably for another issue when/if we actually need it.

Inserting the image into the DOM as <svg> instead of <img> should allow using CSS fill. See https://developers.google.com/maps/documentation/javascript/examples/marker-modern for a possible way to do that, but I haven't looked closely.

We'll also need to support different map tile colors, etc. It's probably best to create "themes" as style variations. The existing WP20 could be the default, then there could be a variation for SotW 2023 which has the red icons, silver map BG, etc.

@iandunn iandunn changed the title Map: Support multiple icon colors Map: Add style variations Nov 16, 2023
@iandunn iandunn self-assigned this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant