Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install appdata files to /usr/share/metainfo/ #3392

Closed
sidt4 opened this issue Sep 23, 2023 · 3 comments
Closed

Install appdata files to /usr/share/metainfo/ #3392

sidt4 opened this issue Sep 23, 2023 · 3 comments
Assignees
Labels
Milestone

Comments

@sidt4
Copy link

sidt4 commented Sep 23, 2023

$ apt-file search /usr/share/appdata/
warzone2100: /usr/share/appdata/net.wz2100.warzone2100.appdata.xml

...
@sidt4 sidt4 added the Bug label Sep 23, 2023
@sidt4
Copy link
Author

sidt4 commented Sep 23, 2023

Notes:

  • Use appstreamcli validate ( and not the deprecated appstream-util validate ) command to validate appstream metainfo files.
  • The metainfo link above contains fallback appdata generated from .desktop file ( if the appdata in not installed in /usr/share/metainfo/ )

@past-due
Copy link
Member

past-due commented Sep 23, 2023

There were some historical reasons to use the original /usr/share/appdata/ path, but it's probably about time we can update this to /usr/share/metainfo/

(For building the Flatpak, we do already use appstreamcli validate: https://github.com/Warzone2100/warzone2100/blob/d92ee42e7b5a14357f287c30490c56cd7dc08d71/.ci/flatpak/build.sh#L42C3-L42C24)

@past-due past-due self-assigned this Sep 23, 2023
@past-due past-due added this to the 4.4.0-beta1 milestone Sep 23, 2023
@past-due
Copy link
Member

PR #3423 makes some improvements to the appstream file info.

Of note: we were actually already installing it to /usr/share/metainfo/

The report you referenced seems to be in regards to the debian repo's package - you would probably want to contact the debian maintainers to get that fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants