New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol Buffer support #61

Open

lassik opened this issue Sep 20, 2018 · 4 comments

Labels

enhancement good first issue help wanted

Contributor

lassik commented Sep 20, 2018

clang-format can also format Protocol Buffer definition files but it's not currently included in the languages list in src/index.ts.

The text was updated successfully, but these errors were encountered:

Contributor

stevenzeck commented Sep 20, 2018

https://github.com/Unibeautify/unibeautify/blob/master/src/languages.json#L6120-L6128 should probably be updated. Extensions at the very least.

Member

Glavin001 commented Sep 21, 2018

Pull Requests very welcome!

Update language:
- https://github.com/Unibeautify/unibeautify/blob/master/src/languages.json#L6120-L6128
- File extensions (has 1 currently, any more @lassik ?)
- VSCode language IDs
Add Protocol Buffer language support:
- https://github.com/Unibeautify/beautifier-clang-format/blob/master/src/index.ts#L48-L54
Add test(s)

Glavin001 added enhancement help wanted good first issue labels

Contributor Author

lassik commented Sep 21, 2018

Can this be done automatically by scripts/update-languages.ts? Protocol Buffer definitions are now recognized by GItHub Linguist.

Member

Glavin001 commented Sep 21, 2018

Yes, good point. Running the script would be the ideal process. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment